fix: moves COPILOT_HOOKS_DENY_DEMO guard to ensure deny() in scope#43103
fix: moves COPILOT_HOOKS_DENY_DEMO guard to ensure deny() in scope#43103ohainle wants to merge 1 commit intogithub:mainfrom
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
Why:
Closes: #43102
What's being changed (if available, include any code snippets, screenshots, or gifs):
This PR addresses the script failures discussed in #43102, amending the
pre-tool-policy.shbash example script listed at https://docs.github.com/en/copilot/tutorials/copilot-cli-hooks#example-script-bash.By moving the
COPILOT_HOOKS_DENY_DEMOguard to below thedeny()declaration, we ensure thatdeny()is always in scope when invoked.Note
This PR only addresses the bash examples, as I don't currently have access to a PowerShell environment to reproduce and confirm the issue on that end.
I'm happy for this PR to be hijacked and updated with PowerShell fixes, if convenient.
Otherwise, the issue should remain open until PowerShell examples have been investigated, and if necessary amended.
Check off the following: