Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AWS SQS instrumentation to correctly use OpenTelemetry semantic conventions for messaging attributes. The changes align the implementation with the official OTel semconv specifications for AWS SQS and messaging systems.
Key Changes:
- Added proper AWS SQS-specific attributes (
aws.sqs.queue.url) alongside messaging semantic conventions - Implemented queue name extraction from SQS queue URLs to populate
messaging.destination.name - Added operation-specific attributes (
messaging.operation.type) for send, receive, and settle operations - Enhanced attribute extraction to include
server.addressand optionallyserver.portfrom queue URLs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sqsattributes.go | Implements the core attribute builder logic with new queueUrlAttrs helper function to extract server address, port, and queue name from SQS URLs; adds messaging operation types and batch message counts |
| sqsattributes_test.go | Updates all test cases to verify the new semantic convention attributes including queue URL, destination name, operation types, and server address |
| attributes_test.go | Updates the default attribute builder test to use the new test fixtures and verify the expanded set of attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws.sqs.*From the OTel semantic conventions docs for
aws.sqs.*:messaging.*From the OTel semantic conventions docs for
messaging.*:server.*From the OTel semantic conventions docs for
server.*:Related
valkey.dialspan attributes valkey-io/valkey-go#94server.*attrs in more cases valkey-io/valkey-go#95