Add golden e2e tests for ibm-mq-metrics#2119
Open
atoulme wants to merge 3 commits intoopen-telemetry:mainfrom
Open
Add golden e2e tests for ibm-mq-metrics#2119atoulme wants to merge 3 commits intoopen-telemetry:mainfrom
atoulme wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
atoulme
force-pushed
the
add_golden
branch
4 times, most recently
from
2b66a8f to
60da846
Compare
atoulme
force-pushed
the
add_golden
branch
4 times, most recently
from
d974838 to
c4e8ef8
Compare
Contributor
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
Contributor
|
@atoulme are you chasing that failure? |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “golden” end-to-end (e2e) test setup for the ibm-mq-metrics component to validate emitted OTLP metrics against an expected snapshot, helping prevent regressions (Fixes #2112).
Changes:
- Adds a docker-compose-based golden test harness (MQ + Collector + Golden) and expected metrics snapshot.
- Adds a Gradle task to copy the IBM MQ client JAR for use by the golden test runner script.
- Updates channel metrics collection to honor the
ibm.mq.manager.active.channelsenablement flag.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/metricscollector/ChannelMetricsCollector.java |
Gates activeChannelsGauge emission behind metrics config. |
ibm-mq-metrics/build.gradle.kts |
Adds copyIbmClientJar task to place MQ client JAR in build/libs. |
ibm-mq-metrics/golden/run.sh |
Runs the built shadow JAR against the golden config. |
ibm-mq-metrics/golden/otelconf.yaml |
Collector config for receiving OTLP and exporting to the golden verifier. |
ibm-mq-metrics/golden/docker-compose.yaml |
Brings up MQ, collector, and golden verifier containers. |
ibm-mq-metrics/golden/data/expected.yaml |
Golden expected metrics snapshot. |
ibm-mq-metrics/golden/config.yml |
IBM MQ metrics app config used for the golden run. |
.github/workflows/e2e.yml |
GitHub Actions workflow to run the golden e2e test on changes. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Test changes to add an e2e test for the ibm-mq-metrics component.
Existing Issue(s):
Fixes #2112