chore: replace read-pkg with read-package-json-fast#745
Open
mehulkar wants to merge 1 commit intosemantic-release:masterfrom
Open
chore: replace read-pkg with read-package-json-fast#745mehulkar wants to merge 1 commit intosemantic-release:masterfrom
mehulkar wants to merge 1 commit intosemantic-release:masterfrom
Conversation
Author
|
@travi would you be able to help shepherd this in? |
mehulkar
commented
Jan 31, 2024
| } = await t.throwsAsync(getPkg({}, { cwd })); | ||
|
|
||
| t.is(error.name, "JSONError"); | ||
| t.is(error.name, "JSONParseError"); |
Author
There was a problem hiding this comment.
This could technically be seen as a breaking change1. The underlying libraries just use different error classes.
read-pkgusesparse-jsonwhich throws aJSONErrorread-package-json-fastuses [json-parse-even-better-errors](https://github.com/npm/json-parse-even-better-errors throws)JSONParseError
Footnotes
-
considering this is a
semantic-releaselibrary, I'm guessing the change is breaking? ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explanation of this PR is given in an "ecosystem cleanup" effort. My role is to do the grunt work to make progress on this effort, so my understanding of each task is minimal for this first pass. If there are concerns about merging this, I am happy to dig in further and make a stronger case!